Keep message edits expanded on mobile - #4097
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Sent-message and queued-message edits reused the follow-up composer’s compact mobile behavior. After focus left an inline edit, its draft collapsed to a single row and hid the editing controls. There is no dedicated issue for this layout bug; nearby queued-editing issues #1864 and #2401 are separate.
What changed
Added an edit-specific expanded preference to
FollowUpPromptBoxand opted in the main-thread sent and queued editors plus the embedded-chat queued editor. The derived expanded state drives the compact layout, mobile CSS, and height animation. The ordinary follow-up composer keeps its existing default. Synthetic before/after screenshots are indocs/assets/message-editing/.How you verified
pnpm exec turbo run test typecheck --filter=@bb/app— 5,077 tests passed, 6 skipped; typecheck passed.pnpm exec turbo run lint --filter=@bb/app— 0 errors.compact: true, expanded: false. After:compact: false, expanded: true.